Skip to content

chore: update to Go 1.24.6 [IDE-1377] #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rrama
Copy link
Contributor

@rrama rrama commented Aug 8, 2025

make generate was broken before I updated the version, so I haven't run it. Bit of a running theme...

N.b. the cimg 1.24.6 tag is not out yet.

Copy link

snyk-io bot commented Aug 8, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link

snyk-io bot commented Aug 8, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@rrama rrama marked this pull request as ready for review August 8, 2025 15:49
@rrama rrama requested review from a team as code owners August 8, 2025 15:49
cursor[bot]

This comment was marked as outdated.

@@ -8,7 +8,7 @@ orbs:
base_image: &base_image
resource_class: small
docker:
- image: cimg/go:1.22
- image: cimg/go:1.24.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Go Version Mismatch Causes CI/Local Discrepancy

Go version mismatch: go.mod specifies Go 1.24.6, but the CircleCI configuration (.circleci/config.yml) uses cimg/go:1.24.5. This inconsistency can lead to divergent build and test behavior between CI and local development environments.

Additional Locations (1)
Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the commit message, the 1.24.6 tag is not out yet.

@PeterSchafer
Copy link
Contributor

Question: @rrama I'm wondering if we make our life easier when we remove the minor version in the go version. Just saying 1.24 should be sufficient. The final version will be determined by the integrating application like the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants